From 518064cc1becb9731e47b0b1fe3c5f41c7fab156 Mon Sep 17 00:00:00 2001 From: InsanusMokrassar Date: Mon, 4 Nov 2019 14:31:53 +0600 Subject: [PATCH] remove @Synchronized and add comment about thread-unsafety of InMemoryPostsAPI --- .../postssystem/core/api/InMemoryPostsAPI.kt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/test/kotlin/com/insanusmokrassar/postssystem/core/api/InMemoryPostsAPI.kt b/core/src/test/kotlin/com/insanusmokrassar/postssystem/core/api/InMemoryPostsAPI.kt index 0bb3bf48..c932a4f4 100644 --- a/core/src/test/kotlin/com/insanusmokrassar/postssystem/core/api/InMemoryPostsAPI.kt +++ b/core/src/test/kotlin/com/insanusmokrassar/postssystem/core/api/InMemoryPostsAPI.kt @@ -15,6 +15,9 @@ import java.util.* @ImplicitReflectionSerializer private fun generateId(): PostId = UUID.randomUUID().toString() +/** + * Thread-unsafe sample realization of [PostsAPI] + */ @ImplicitReflectionSerializer class InMemoryPostsAPI( initialPosts: List = emptyList() @@ -34,7 +37,6 @@ class InMemoryPostsAPI( override val postUpdatedFlow: Flow = postUpdatedBroadcastChannel.asFlow() - @Synchronized override suspend fun createPost(post: Post): RegisteredPost? { return SimpleRegisteredPost( generateId(), @@ -45,14 +47,12 @@ class InMemoryPostsAPI( } } - @Synchronized override suspend fun deletePost(id: PostId): Boolean { return posts.remove(id) ?.also { postDeletedBroadcastChannel.send(it) } != null } - @Synchronized override suspend fun updatePostContent(postId: PostId, post: Post): Boolean { return getPostById(postId) ?.also { dbPost -> val newPost = SimpleRegisteredPost(