Merge pull request #655 from InsanusMokrassar/3.2.5

3.2.5

CHANGELOG.md

@@ -1,5 +1,10 @@
 # TelegramBotAPI changelog
 
+## 3.2.5
+
+* `Common`:
+  * Improve support of new exceptions recovering mechanism
+
 ## 3.2.4
 
 * `API`:

gradle.properties

@@ -6,4 +6,4 @@ kotlin.incremental=true
 kotlin.incremental.js=true
 
 library_group=dev.inmo
-library_version=3.2.4
+library_version=3.2.5

tgbotapi.core/src/commonMain/kotlin/dev/inmo/tgbotapi/bot/exceptions/RequestException.kt

@@ -4,6 +4,7 @@ import com.soywiz.klock.DateTime
 import dev.inmo.tgbotapi.types.Response
 import dev.inmo.tgbotapi.types.RetryAfterError
 import io.ktor.utils.io.errors.IOException
+import kotlinx.coroutines.CopyableThrowable
 
 fun newRequestException(
     response: Response,
@@ -35,9 +36,11 @@ fun newRequestException(
     }
 } ?: CommonRequestException(response, plainAnswer, message, cause)
 
-sealed class BotException(message: String = "Something went wrong", cause: Throwable? = null) : IOException(message, cause)
+sealed class BotException(message: String = "Something went wrong", cause: Throwable? = null) : IOException(message, cause), CopyableThrowable<BotException>
 
-class CommonBotException(message: String = "Something went wrong", cause: Throwable? = null) : BotException(message, cause)
+class CommonBotException(message: String = "Something went wrong", cause: Throwable? = null) : BotException(message, cause) {
+    override fun createCopy(): BotException = CommonBotException(message!!, cause)
+}
 
 sealed class RequestException constructor(
     val response: Response,
@@ -50,28 +53,46 @@ sealed class RequestException constructor(
 )
 
 class CommonRequestException(response: Response, plainAnswer: String, message: String?, cause: Throwable?) :
-    RequestException(response, plainAnswer, message, cause)
+    RequestException(response, plainAnswer, message, cause) {
+    override fun createCopy(): BotException = CommonRequestException(response, plainAnswer, message, cause)
+}
 
 class UnauthorizedException(response: Response, plainAnswer: String, message: String?, cause: Throwable?) :
-    RequestException(response, plainAnswer, message, cause)
+    RequestException(response, plainAnswer, message, cause) {
+    override fun createCopy(): BotException = UnauthorizedException(response, plainAnswer, message, cause)
+}
 
 class ReplyMessageNotFoundException(response: Response, plainAnswer: String, message: String?, cause: Throwable?) :
-    RequestException(response, plainAnswer, message, cause)
+    RequestException(response, plainAnswer, message, cause) {
+    override fun createCopy(): BotException = ReplyMessageNotFoundException(response, plainAnswer, message, cause)
+}
 
 class MessageIsNotModifiedException(response: Response, plainAnswer: String, message: String?, cause: Throwable?) :
-    RequestException(response, plainAnswer, message, cause)
+    RequestException(response, plainAnswer, message, cause) {
+    override fun createCopy(): BotException = MessageIsNotModifiedException(response, plainAnswer, message, cause)
+}
 
 class MessageToEditNotFoundException(response: Response, plainAnswer: String, message: String?, cause: Throwable?) :
-    RequestException(response, plainAnswer, message, cause)
+    RequestException(response, plainAnswer, message, cause) {
+    override fun createCopy(): BotException = MessageToEditNotFoundException(response, plainAnswer, message, cause)
+}
 
 class InvalidPhotoDimensionsException(response: Response, plainAnswer: String, message: String?, cause: Throwable?) :
-    RequestException(response, plainAnswer, message, cause)
+    RequestException(response, plainAnswer, message, cause) {
+    override fun createCopy(): BotException = InvalidPhotoDimensionsException(response, plainAnswer, message, cause)
+}
 
 class WrongFileIdentifierException(response: Response, plainAnswer: String, message: String?, cause: Throwable?) :
-    RequestException(response, plainAnswer, message, cause)
+    RequestException(response, plainAnswer, message, cause) {
+    override fun createCopy(): BotException = WrongFileIdentifierException(response, plainAnswer, message, cause)
+}
 
 class TooMuchRequestsException(val retryAfter: RetryAfterError, response: Response, plainAnswer: String, message: String?, cause: Throwable?) :
-    RequestException(response, plainAnswer, message, cause)
+    RequestException(response, plainAnswer, message, cause) {
+    override fun createCopy(): BotException = TooMuchRequestsException(retryAfter, response, plainAnswer, message, cause)
+}
 
 class GetUpdatesConflict(response: Response, plainAnswer: String, message: String?, cause: Throwable?) :
-    RequestException(response, plainAnswer, message, cause)
+    RequestException(response, plainAnswer, message, cause) {
+    override fun createCopy(): BotException = GetUpdatesConflict(response, plainAnswer, message, cause)
+}

tgbotapi.core/src/commonMain/kotlin/dev/inmo/tgbotapi/bot/ktor/KtorRequestsExecutor.kt

@@ -77,21 +77,23 @@ class KtorRequestsExecutor(
             val result = it.exceptionOrNull() ?.let { e ->
                 pipelineStepsHolder.onRequestException(request, e) ?.let { return@let it }
 
-                if (e is ClientRequestException) {
+                when (e) {
-                    val exceptionResult = runCatchingSafely {
+                    is ClientRequestException -> {
-                        val content = e.response.bodyAsText()
+                        val exceptionResult = runCatchingSafely {
-                        val responseObject = jsonFormatter.decodeFromString(Response.serializer(), content)
+                            val content = e.response.bodyAsText()
-                        newRequestException(
+                            val responseObject = jsonFormatter.decodeFromString(Response.serializer(), content)
-                            responseObject,
+                            newRequestException(
-                            content,
+                                responseObject,
-                            "Can't get result object from $content"
+                                content,
-                        )
+                                "Can't get result object from $content"
+                            )
+                        }
+                        exceptionResult.exceptionOrNull() ?.let {
+                            CommonBotException(cause = e)
+                        } ?: exceptionResult.getOrThrow()
                     }
-                    exceptionResult.exceptionOrNull() ?.let {
+                    is BotException -> e
-                        CommonBotException(cause = e)
+                    else -> CommonBotException(cause = e)
-                    } ?: exceptionResult.getOrThrow()
-                } else {
-                    CommonBotException(cause = e)
                 }
             } ?.let { Result.failure(it) } ?: it
             pipelineStepsHolder.onRequestReturnResult(result, request, callsFactories)

tgbotapi.utils/src/commonMain/kotlin/dev/inmo/tgbotapi/extensions/utils/updates/retrieving/LongPolling.kt

@@ -3,8 +3,7 @@ package dev.inmo.tgbotapi.extensions.utils.updates.retrieving
 import dev.inmo.micro_utils.coroutines.*
 import dev.inmo.tgbotapi.bot.RequestsExecutor
 import dev.inmo.tgbotapi.bot.TelegramBot
-import dev.inmo.tgbotapi.bot.exceptions.GetUpdatesConflict
+import dev.inmo.tgbotapi.bot.exceptions.*
-import dev.inmo.tgbotapi.bot.exceptions.RequestException
 import dev.inmo.tgbotapi.extensions.utils.updates.convertWithMediaGroupUpdates
 import dev.inmo.tgbotapi.extensions.utils.updates.lastUpdateIdentifier
 import dev.inmo.tgbotapi.requests.GetUpdates
@@ -101,10 +100,10 @@ fun TelegramBot.createAccumulatedUpdatesRetrieverFlow(
 ): Flow<Update> = longPollingFlow(
     timeoutSeconds = 0,
     exceptionsHandler = {
-        if (it is HttpRequestTimeoutException) {
+        when {
-            throw CancellationException("Cancel due to absence of new updates")
+            it is HttpRequestTimeoutException ||
-        } else {
+            (it is CommonBotException && it.cause is HttpRequestTimeoutException) -> throw CancellationException("Cancel due to absence of new updates")
-            exceptionsHandler ?.invoke(it)
+            else -> exceptionsHandler ?.invoke(it)
         }
     },
     allowedUpdates = allowedUpdates